Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 使用脚本执行插件配置，脚本在最后应该restart服务 #2699

Merged
merged 6 commits into from
Nov 6, 2024
Merged

fix: 使用脚本执行插件配置，脚本在最后应该restart服务 #2699

merged 6 commits into from
Nov 6, 2024

Conversation

littleniannian
Copy link
Collaborator

@littleniannian littleniannian commented Oct 21, 2024 •
edited
Loading

关联的 issue

#2682

描述你的变更

  • 在functions.sh中增加restart_sqle方法
  • restart_sqle方法的具体实现是先执行stop_sqle.sh, 后执行init_start.sh

确认项（pr提交后操作）

Tip

请在指定复审人之前，确认并完成以下事项，完成后✅

  • 我已完成自测
  • 我已在关联的issue里补充了实现方案
  • 我已在关联的issue里补充了测试影响面
  • 我已确认了变更的兼容性，如果不兼容则在issue里标记 not_compatible
  • 我已确认了是否要更新文档，如果要更新则在issue里标记 need_update_doc

assign in @winfredLIN

@ColdWaterLW ColdWaterLW added this to the v3.2410.0 milestone Oct 25, 2024
@ColdWaterLW ColdWaterLW removed this from the v3.2410.0 milestone Oct 28, 2024
@littleniannian
Copy link
Collaborator Author

  • 重启脚本需要判断SQLE的进程是否存在来决定是直接启动，还是关闭后启动
  • stop_sqle.sh需要判断SQLE是否被正常关闭

@littleniannian
Copy link
Collaborator Author

自测

SQLE已启动

  • 先停止SQLE，再启动
    image

SQLE未启动

image

winfredLIN
winfredLIN reviewed Nov 6, 2024
View reviewed changes
scripts/functions.sh Outdated Show resolved Hide resolved
winfredLIN
winfredLIN reviewed Nov 6, 2024
View reviewed changes
scripts/init_config.sh Outdated Show resolved Hide resolved
@winfredLIN winfredLIN merged commit 60a384c into main Nov 6, 2024
3 checks passed
@ColdWaterLW ColdWaterLW deleted the fix_init_config_restart branch November 7, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winfredLIN winfredLIN winfredLIN approved these changes

@ColdWaterLW ColdWaterLW Awaiting requested review from ColdWaterLW

Assignees
No one assigned
Labels
publish-rel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@littleniannian @winfredLIN @ColdWaterLW